(torchx/runner) properly log appdef properties in dryrun #1159
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@kiukchung has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86014124. |
kiukchung
added a commit
that referenced
this pull request
Nov 1, 2025
Summary: We were not logging all the information about the appdef in the dryrun API. Differential Revision: D86014124
kiukchung
force-pushed
the
export-D86014124
branch
from
76be0cb to
fba54b4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
=======================================
Coverage 91.62% 91.63%
=======================================
Files 84 84
Lines 6589 6595 +6
=======================================
+ Hits 6037 6043 +6
Misses 552 552
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kiukchung
added a commit
that referenced
this pull request
Nov 2, 2025
Summary: We were not logging all the information about the appdef in the dryrun API. Differential Revision: D86014124
kiukchung
force-pushed
the
export-D86014124
branch
from
fba54b4 to
e9ba5f5
Compare
Summary: We were not logging all the information about the appdef in the dryrun API. Differential Revision: D86014124
kiukchung
force-pushed
the
export-D86014124
branch
from
e9ba5f5 to
c4d3521
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We were not logging all the information about the appdef in the dryrun API.
Differential Revision: D86014124