Skip to content

(torchx/specs) Remove deprecated base_image attribute from Role #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(torchx/specs) Remove deprecated base_image attribute from Role #1138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions torchx/schedulers/test/kubernetes_mcad_scheduler_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,6 @@ def test_get_role_information(
name="echo",
image="echoImage",
min_replicas=None,
base_image=None,
args=[
"bash",
"-c",
Expand Down Expand Up @@ -862,7 +861,6 @@ def test_get_role_information_no_specs(
name="echo",
image="",
min_replicas=None,
base_image=None,
args=[],
env={},
num_replicas=1,
Expand Down Expand Up @@ -926,7 +924,6 @@ def test_get_role_information_no_image_name(
name="echo",
image="",
min_replicas=None,
base_image=None,
args=[],
env={},
num_replicas=1,
Expand Down Expand Up @@ -978,7 +975,6 @@ def test_get_role_information_no_resources(
name="echo",
image="echoImage",
min_replicas=None,
base_image=None,
args=[
"bash",
"-c",
Expand Down Expand Up @@ -1045,7 +1041,6 @@ def test_get_role_information_no_cpu(
name="echo",
image="echoImage",
min_replicas=None,
base_image=None,
args=[
"bash",
"-c",
Expand Down Expand Up @@ -1112,7 +1107,6 @@ def test_get_role_information_no_memory(
name="echo",
image="echoImage",
min_replicas=None,
base_image=None,
args=[
"bash",
"-c",
Expand Down Expand Up @@ -1179,7 +1173,6 @@ def test_get_role_information_no_ports(
name="echo",
image="echoImage",
min_replicas=None,
base_image=None,
args=[
"bash",
"-c",
Expand Down Expand Up @@ -1246,7 +1239,6 @@ def test_get_role_information_no_volume_mounts(
name="echo",
image="echoImage",
min_replicas=None,
base_image=None,
args=[
"bash",
"-c",
Expand Down
1 change: 0 additions & 1 deletion torchx/specs/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,6 @@ class Role:
name: str
image: str
min_replicas: Optional[int] = None
base_image: Optional[str] = None # DEPRECATED DO NOT SET, WILL BE REMOVED SOON
entrypoint: str = MISSING
args: List[str] = field(default_factory=list)
env: Dict[str, str] = field(default_factory=dict)
Expand Down
Loading