Migrate re2 usages #155
Closed
Migrate re2 usages #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This updates the usages of re2 dependencies from `third-party//re2:re2` to `fbsource//third-party/re2:re2` for project white lotus. `third-party//re2:re2` is already translated to `fbsource//third-party/re2:re2` by the white lotus redirection list in, so these changes do NOT cause any functional behavior changes. After all usages of re2 are migrated, the next step is to enable a tripwire on its usage in white_lotus.bzl and then remove existing translations in `deps_remappings.bzl` and `xplat_virtual_cells.bzl` Reviewed By: dtolnay Differential Revision: D86929111
meta-cla
bot
added
the
CLA Signed
Author
|
Moved to #156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This updates the usages of re2 dependencies from
third-party//re2:re2tofbsource//third-party/re2:re2for project white lotus.third-party//re2:re2is already translated tofbsource//third-party/re2:re2by the white lotus redirection list in, so these changes do NOT cause any functional behavior changes.After all usages of re2 are migrated, the next step is to enable a tripwire on its usage in white_lotus.bzl and then remove existing translations in
deps_remappings.bzlandxplat_virtual_cells.bzlReviewed By: dtolnay
Differential Revision: D86929111