freeglut: require GL/glu.h #2118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusma
force-pushed
the
freeglut-search-for-glu
branch
from
de8d1bf to
94e3882
Compare
|
Seems like the MacOS build failure is caused by a github-actions issue: actions/runner-images#9966 |
|
Yeah, testing this locally works fine... |
paulmenzel
approved these changes
May 21, 2025
There was a problem hiding this comment.
Thank you for coming up with a fix for my issue https://gitlab.freedesktop.org/mesa/demos/-/issues/50. The diff looks good to me.
bgilbert
reviewed
May 24, 2025
kusma
force-pushed
the
freeglut-search-for-glu
branch
from
6d4eff0 to
9fe557a
Compare
bgilbert
reviewed
Jun 24, 2025
Freeglut requires GL/glu.h, which isn't always installed. Make sure we check for it, so we can get a meaningful error message early on instead of just failing to compile. Because not all platforms has glu as a dependency, we also need to fall back to searching for the library. This search is copied from Mesa's demos project.
Seems there's an issue where recent python versions will conflict with the version provided by the runner-image. Let's try to work around it. This feels a bit hacky, because we need to hard-code the specific version, suggestions for improvements welcome. See this ticket for details: actions/runner-images#9966
kusma
force-pushed
the
freeglut-search-for-glu
branch
from
9fe557a to
973cd2f
Compare
|
The alpine failures seems unrelated to this MR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Freeglut requires GL/glu.h, which isn't always installed. Make sure we check for it, so we can get a meaningful error message early on instead of just failing to compile.
Because not all platforms has glu as a dependency, we also need to fall back to searching for the library. This search is copied from Mesa's demos project.