Make ExternalNotification show up in excluded_modules, more STM32 modules #7797
+38
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fifieldt
approved these changes
Aug 31, 2025
… flash by dropping weather station support for serialmodule, set tx/rx pins before begin
…de the right pin mapping.
|
I've fixed rak3172 and tested on hardware. |
4 tasks
fifieldt
approved these changes
Sep 2, 2025
thebentern
approved these changes
Sep 2, 2025
thebentern
pushed a commit
that referenced
this pull request
Sep 2, 2025
…ules (#7797) * Show ExternalNotification as excluded if it is * Enable ExternalNotification, SerialModule and RangeTest on STM32WL * Misc fixes for #7797 - ARCH_STM32 -> ARCH_STM32WL, use less flash by dropping weather station support for serialmodule, set tx/rx pins before begin * Enable Serial1 on RAK3172, make SerialModule use it (console is on LPUART1) * Fix SerialModule on RAK3172, fix board definition of RAK3172 to include the right pin mapping.
mehow
pushed a commit
to mehow/meshtastic-firmware
that referenced
this pull request
Sep 5, 2025
…ules (meshtastic#7797) * Show ExternalNotification as excluded if it is * Enable ExternalNotification, SerialModule and RangeTest on STM32WL * Misc fixes for meshtastic#7797 - ARCH_STM32 -> ARCH_STM32WL, use less flash by dropping weather station support for serialmodule, set tx/rx pins before begin * Enable Serial1 on RAK3172, make SerialModule use it (console is on LPUART1) * Fix SerialModule on RAK3172, fix board definition of RAK3172 to include the right pin mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExternalNotification wasn't added to excluded_modules in device metadata, which meshtastic/python#818 relies on.
Also, enable more stuff on STM32, again.
At some point I want to clean up some of these ifdefs into something more manageable, but that'll be a future PR...
🤝 Attestations