Skip to content

Conversation

berlincount
Copy link
Contributor

I've worked on the Heltec Wireless Bridge and

  • configured PSRAM support
  • removed broken Battery & Button support
  • fixed the LED used to the LoRa one
  • added support for BLE & WiFi LEDs
  • added defines to exclude RADIOLIB code and MODULES not making much sense
  • created a boards JSON as best as I could

related: meshtastic/web-flasher#156

🤝 Attestations

  • I have tested that my proposed changes behave as described.
  • I have tested that my proposed changes do not cause any obvious regressions on the following devices:
    • Heltec (Lora32) V3
    • LilyGo T-Deck
    • LilyGo T-Beam
    • RAK WisBlock 4631
    • Seeed Studio T-1000E tracker card (my main device)
    • Other (please specify below)

@berlincount
Copy link
Contributor Author

How does the "Changes requested" get cleared? 🤔 @caveman99

@caveman99
Copy link
Member

How does the "Changes requested" get cleared? 🤔 @caveman99

Sorry for cycling back to you so late, there's an actual compile error in the heltec wireless bridge code that needs ot be addressed. See the output from the CI run.

@berlincount
Copy link
Contributor Author

How does the "Changes requested" get cleared? 🤔 @caveman99

Sorry for cycling back to you so late, there's an actual compile error in the heltec wireless bridge code that needs ot be addressed. See the output from the CI run.

hmmm. I only seem to catch intermittend non-code related CI errors. weird. triggering another branch update to maybe see what's going on.

@berlincount
Copy link
Contributor Author

How does the "Changes requested" get cleared? 🤔 @caveman99

Sorry for cycling back to you so late, there's an actual compile error in the heltec wireless bridge code that needs ot be addressed. See the output from the CI run.

I somehow can't find the CI logs for build-esp32 (heltec-wireless-bridge) builds :-/ it builds without any trouble locally.

what am I doing wrong? am I understanding how to use board = correctly?

@berlincount
Copy link
Contributor Author

Ah-ha! seems like it was "only" a formatting error. should be fine now? 🤔

@fifieldt fifieldt merged commit c6c2a4d into meshtastic:master Jun 10, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants