Skip to content

Conversation

AuraReaper
Copy link

@AuraReaper AuraReaper commented Sep 18, 2025

Description
This PR fixes meshery/meshery#15021

Notes for Reviewers
This PR is part of a multi-repo change to add a createdAt timestamp to model metadata.

This change introduces a createdAt timestamp to the model schema. This is the first step in allowing the frontend to identify and indicate recently added models.

Changes:
Added the createdAt field to model.json.

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Sep 18, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @AuraReaper, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a createdAt timestamp into the model metadata schema, a foundational step for enhancing the user interface by allowing the frontend to highlight and categorize newly registered models. The changes involve modifying schema definitions and regenerating corresponding Go code, ensuring that model metadata accurately captures creation times.

Highlights

  • Model Metadata Enhancement: A createdAt timestamp field has been introduced to the model metadata schema.
  • Frontend Integration: This new field is intended to enable the frontend to identify and display recently added models, improving user experience.
  • Schema Updates: The model.json and merged-openapi.yml schema definitions have been updated to include the new createdAt field.
  • Code Generation Updates: Go models (model.go, badge.go) were regenerated using oapi-codegen v2.5.0, which also involved cleaning up redundant yaml tags.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds the createdAt field to the model metadata, which is a good enhancement. However, the process of regenerating the models has introduced a significant regression: yaml struct tags have been removed from numerous fields across multiple generated Go files. This will likely break YAML serialization and appears to be an unintended side effect. The root cause seems to be an issue with the generate-golang.sh script, which should be fixed before this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adding created_at/added field inside the registry model metadata

1 participant