-
Notifications
You must be signed in to change notification settings - Fork 722
Fixed Alignment and uniform styles #2391 #2392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @Flashl3opard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical visual regression on the GSoD page by re-establishing proper CSS padding for text elements, ensuring content is correctly indented and readable. It also significantly refactors and enhances the responsive design of the page, providing a more consistent and user-friendly experience across all devices. The changes aim to improve the aesthetic and functional presentation of the GSoD program information. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Signed-off-by: FlashL3opard <[email protected]>
bd0dad1 to
b440e7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant refactoring of the CSS for the GSoD page to fix alignment issues and improve code quality. The changes are extensive and well-structured, using comments to organize the stylesheet and simplifying many CSS rules. Responsiveness is also improved with new media queries for different screen sizes. My review includes a few suggestions to further improve maintainability, such as addressing a file naming inconsistency and removing redundant or problematic CSS rules. Overall, this is a great improvement to the codebase.
Signed-off-by: FlashL3opard <[email protected]>
Signed-off-by: FlashL3opard <[email protected]>
Signed-off-by: FlashL3opard <[email protected]>
|
Thank you for your contribution! |
|
@Flashl3opard I think this can be done with minimal changes. Could you try testing it with the minimum required modifications? |
Description
This PR fixes #2391 a CSS alignment regression on the GSoD page. A recent refactor had reset
padding-leftvalues to0for most text content, causing paragraphs, headings, and lists to align hard-left, which looked broken and was difficult to read.This PR restores the correct
padding-leftvalues to the following elements to ensure consistent indentation:<p><h3>and<h4>.program ol.project-list.program-p.subhead.issueIt also ensures that the mobile-specific padding overrides are correctly applied.
Screenshots
Before
After
Signed commits