-
Notifications
You must be signed in to change notification settings - Fork 714
[Docs] Fix broken links in Newcomers map and enable Community Handbook #2350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Docs] Fix broken links in Newcomers map and enable Community Handbook #2350
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack. |
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @phoenixcodeforces-blip, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for newcomers by resolving several broken links across the Newcomers map and community pages. It also improves accessibility by adding Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses broken links in the Newcomers map and enhances accessibility by adding aria-label
attributes. The changes are clear and align with the description. My review includes a couple of suggestions to ensure consistency in handling external links across all modified files, aligning with the PR's goal of opening them in a new tab with appropriate security attributes. Overall, this is a valuable contribution to improving the site's usability and accessibility.
@phoenixcodeforces-blip can you look over the merge conflicts . The community guide should ideally be going to https://meshery.io/community/ , as handbook is not there |
@Namanv0509 |
Signed-off-by: phoenixcodeforces-blip <[email protected]>
ec3a079
to
b59672b
Compare
Hi @Namanv0509 Thank you. |
Description
This PR fixes #2348 by resolving all broken links in the Newcomers map and implementing accessibility improvements.
Changes Made
Fixed Broken Links (4 total)
/newcomers
pagehttps://github.com/meshery/meshery
published: false
fromcollections/_pages/handbook.html
/newcomers
Additional Improvements
aria-label
attributes to all links for screen reader accessibilitycollections/_handbook/about.md
Files Modified
_includes/newcomers-map.html
community.html
_includes/partials/community.html
collections/_handbook/about.md
collections/_pages/handbook.html
Verification
All links in the Newcomers map tested and verified working:
Notes for Reviewers
All changes tested for linting errors. Accessibility improvements follow WCAG guidelines.
[Signed commits](https://docs.meshery.io/project/contributing#signing-off-on-commits-developer-certificate-of-origin)