Skip to content

Conversation

phoenixcodeforces-blip
Copy link

@phoenixcodeforces-blip phoenixcodeforces-blip commented Sep 29, 2025

Description

This PR fixes #2348 by resolving all broken links in the Newcomers map and implementing accessibility improvements.

Changes Made

Fixed Broken Links (4 total)

  1. Newcomers' Guide - Changed from broken external link to local /newcomers page
  2. Repository Overview - Changed from non-functional handbook link to https://github.com/meshery/meshery
  3. Community Handbook - Enabled page publication by removing published: false from collections/_pages/handbook.html
  4. Community Page Link - Updated Newcomers Journey link to /newcomers

Additional Improvements

  • Added aria-label attributes to all links for screen reader accessibility
  • Fixed typo: "community calender" → "community calendar"
  • Configured proper link behavior (local links in same tab, external links in new tab with security attributes)
  • Fixed markdown linting error in collections/_handbook/about.md

Files Modified

_includes/newcomers-map.html community.html _includes/partials/community.html collections/_handbook/about.md collections/_pages/handbook.html

Verification

All links in the Newcomers map tested and verified working:

  • ✅ Newcomers' Guide, Find a Meshmate, Newcomers' Meeting, Community Guide, Repository Overview

Notes for Reviewers

All changes tested for linting errors. Accessibility improvements follow WCAG guidelines.

[Signed commits](https://docs.meshery.io/project/contributing#signing-off-on-commits-developer-certificate-of-origin)

  • Yes, I signed my commits.

Copy link

welcome bot commented Sep 29, 2025

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented Sep 29, 2025

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit eca6eac
🔍 Latest deploy log https://app.netlify.com/projects/mesheryio-preview/deploys/68e7d98f17a3920008ddd154
😎 Deploy Preview https://deploy-preview-2350--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Summary of Changes

Hello @phoenixcodeforces-blip, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience for newcomers by resolving several broken links across the Newcomers map and community pages. It also improves accessibility by adding aria-label attributes to links and activates the Community Handbook, making valuable resources readily available. These changes ensure a smoother onboarding process and better navigation for community members.

Highlights

  • Link Fixes: Addressed four broken links within the Newcomers map and related community pages, redirecting them to correct local paths or the Meshery GitHub repository.
  • Accessibility Enhancements: Integrated aria-label attributes across various links to improve screen reader compatibility and overall accessibility.
  • Community Handbook Activation: Enabled the Community Handbook page by removing its published: false flag, making it accessible to users.
  • Typographical Correction: Fixed a minor typo from "community calender" to "community calendar" for improved accuracy.
  • Link Behavior Standardization: Configured links to open local pages in the same tab and external links in new tabs with appropriate security attributes (rel="noreferrer").
  • Markdown Linting: Resolved a markdown linting error by removing an extraneous blank line in the handbook's about.md file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses broken links in the Newcomers map and enhances accessibility by adding aria-label attributes. The changes are clear and align with the description. My review includes a couple of suggestions to ensure consistency in handling external links across all modified files, aligning with the PR's goal of opening them in a new tab with appropriate security attributes. Overall, this is a valuable contribution to improving the site's usability and accessibility.

@Namanv0509
Copy link
Member

@phoenixcodeforces-blip can you look over the merge conflicts .

The community guide should ideally be going to https://meshery.io/community/ , as handbook is not there

@phoenixcodeforces-blip
Copy link
Author

@Namanv0509
Thank you for your review, I will fix it.

@phoenixcodeforces-blip
Copy link
Author

Hi @Namanv0509
I have made the changes as instructed by you and I have resolved the conflicts,
Please review it, and suggest if any changes are required.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Most of the links in the Newcomers map don't work.
2 participants