feat: seller api keys #127
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vholik
reviewed
Mar 27, 2025
vholik
reviewed
Mar 27, 2025
vholik
reviewed
Mar 27, 2025
| const { | ||
| data: [api_key] | ||
| } = await query.graph({ | ||
| entity: 'seller_api_key', |
There was a problem hiding this comment.
why dont just use medusa secret api keys with created_by with seller auth context actor id?
There was a problem hiding this comment.
Medusa supports only one active secret key in the database at the time: https://github.com/medusajs/medusa/blob/develop/packages/modules/api-key/src/services/api-key-module-service.ts#L480
Their api-key implementation is clearly meant only for admin at the moment
vholik
reviewed
Mar 27, 2025
| ) => { | ||
| const query = container.resolve(ContainerRegistrationKeys.QUERY) | ||
|
|
||
| await revokeSellerApiKeyWorkflow.run({ |
vholik
reviewed
Mar 27, 2025
| const query = container.resolve(ContainerRegistrationKeys.QUERY) | ||
|
|
||
| const { data: api_keys, metadata } = await query.graph({ | ||
| entity: 'seller_api_key', |
vholik
reviewed
Mar 27, 2025
vholik
reviewed
Mar 27, 2025
| @@ -121,6 +129,22 @@ class SellerModuleService extends MedusaService({ | |||
| }) | |||
| } | |||
|
|
|||
| public async generateSecretKey() { | |||
There was a problem hiding this comment.
same question goes why dont jsut use default medusa module?
vholik
reviewed
Mar 27, 2025
| let normalizedToken = token | ||
| if (!token.startsWith('ssk_')) { | ||
| normalizedToken = Buffer.from(token, 'base64').toString('utf-8') | ||
| } |
vholik
reviewed
Mar 27, 2025
| return fetchSellerByAuthActorId(ctx.actor_id, scope, fields) | ||
| } | ||
|
|
||
| if (ctx.actor_type === 'seller-api-key') { |
slusarczykmichal
force-pushed
the
feat/api-keys
branch
from
17184a4 to
ff26da8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.