Skip to content

fix: accessibility issue with slider ariaLabelledBy #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: accessibility issue with slider ariaLabelledBy #1983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/slider-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@mendix/slider-web",
"widgetName": "Slider",
"version": "2.1.4",
"version": "2.1.5",
"description": "Change a number value using a slider",
"copyright": "© Mendix Technology BV 2025. All rights reserved.",
"license": "Apache-2.0",
Expand Down
3 changes: 3 additions & 0 deletions packages/pluggableWidgets/slider-web/src/components/Container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ function InnerContainer(props: InnerContainerProps): ReactElement {
min: props.min,
max: props.max
});
// Label generated by systemProperty has the format: {widgetId}-label
const ariaLabelledByForHandle = `${props.id}-label`;

return (
<SliderComponent
Expand All @@ -58,6 +60,7 @@ function InnerContainer(props: InnerContainerProps): ReactElement {
step={props.step}
onChange={onChange}
marks={marks}
ariaLabelledByForHandle={ariaLabelledByForHandle}
handleRender={handleRender}
ref={sliderRef}
/>
Expand Down
3 changes: 2 additions & 1 deletion packages/pluggableWidgets/slider-web/src/components/__tests__/Slider.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ describe("Slider", () => {
const defaultSliderProps: SliderProps = {
min: -100,
max: 100,
step: 10
step: 10,
ariaLabelledByForHandle: "test-slider"
};

function renderSlider(props?: Partial<SliderProps>): ReturnType<typeof render> {
Expand Down
3 changes: 3 additions & 0 deletions ...s/pluggableWidgets/slider-web/src/components/__tests__/__snapshots__/Slider.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ exports[`Slider renders horizontal Slider correctly 1`] = `
/>
<div
aria-disabled="false"
aria-labelledby="test-slider"
aria-orientation="horizontal"
aria-valuemax="100"
aria-valuemin="-100"
Expand Down Expand Up @@ -75,6 +76,7 @@ exports[`Slider renders markers correctly 1`] = `
</div>
<div
aria-disabled="false"
aria-labelledby="test-slider"
aria-orientation="horizontal"
aria-valuemax="100"
aria-valuemin="-100"
Expand Down Expand Up @@ -143,6 +145,7 @@ exports[`Slider renders vertical Slider correctly 1`] = `
/>
<div
aria-disabled="false"
aria-labelledby="test-slider"
aria-orientation="vertical"
aria-valuemax="100"
aria-valuemin="-100"
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/slider-web/src/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<package xmlns="http://www.mendix.com/package/1.0/">
<clientModule name="Slider" version="2.1.4" xmlns="http://www.mendix.com/clientModule/1.0/">
<clientModule name="Slider" version="2.1.5" xmlns="http://www.mendix.com/clientModule/1.0/">
<widgetFiles>
<widgetFile path="Slider.xml" />
</widgetFiles>
Expand Down
Loading