Skip to content

[WC-3052] DataWidget: Styling variables cleanup #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yordan-st
Copy link
Collaborator

Pull request type

Refactoring (e.g. file rename, variable rename, etc.)


Description

Consolidated all SCSS variables from individual files into variables.scss to eliminate duplicates and create a single source of truth for theming, adding !default flags for easier overrides.

What should be covered while testing?

  • All data grid components render with correct colors, spacing, and styling
  • Filter dropdowns, buttons, and icons display properly
  • Hover states, selected states, and focus styles work as expected
  • Variables can be overridden using !default mechanism
  • CSS custom properties update correctly at runtime
  • No duplicate or conflicting styles applied

@yordan-st yordan-st requested a review from a team as a code owner August 15, 2025 09:27
@yordan-st yordan-st force-pushed the feat/WC-3052_datawidget-styling-variables-cleanup branch 2 times, most recently from 892cbfb to bc53cd1 Compare August 19, 2025 08:45
@gjulivan gjulivan force-pushed the feat/WC-3052_datawidget-styling-variables-cleanup branch from bc53cd1 to e462bc5 Compare August 19, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants