[WC-349]: Prevent scroll on column selector focus #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0b1n
reviewed
Aug 12, 2025
packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx
Outdated
Show resolved
Hide resolved
rahmanunver
force-pushed
the
fix/wc-3049_column_selector_scroll
branch
from
7905fbc to
c71b2ea
Compare
|
need rebase @rahmanunver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
The referenced column selector element was being focused after loading DG2 as a solution for focus behavior, it was causing a horizontal scroll issue on initial load. We are keeping the focus behavior same but preventing the scroll now.
What should be covered while testing?
A dg2 nested in container with column selector enabled. See the test project.