Skip to content

[WC-3050] Retrieve pdfjs worker locally instead of cdn #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gjulivan
Copy link
Collaborator

@gjulivan gjulivan commented Aug 10, 2025

Pull request type


Description

pdfjs-dist version has to be the same with react-pdf dependency
https://github.com/wojtekmaj/react-pdf/blob/5e0d135f5d1d3a3cec4628a2fc05a4a8f0bed9e7/packages/react-pdf/package.json#L60
this version use "4.8.69"

@gjulivan gjulivan force-pushed the document-viewer-local-pdfjs branch 6 times, most recently from 03e05ee to 2f12295 Compare August 11, 2025 20:01
@gjulivan gjulivan marked this pull request as ready for review August 11, 2025 20:02
@gjulivan gjulivan requested a review from a team as a code owner August 11, 2025 20:02
@gjulivan gjulivan changed the title Retrieve pdfjs worker locally instead of cdn [WC-3050] Retrieve pdfjs worker locally instead of cdn Aug 11, 2025
@gjulivan gjulivan force-pushed the document-viewer-local-pdfjs branch 2 times, most recently from 7908040 to 2bddeee Compare August 12, 2025 11:15
Copy link
Collaborator

@iobuhov iobuhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gjulivan gjulivan force-pushed the document-viewer-local-pdfjs branch from 2bddeee to 27561ca Compare August 18, 2025 17:25
@gjulivan gjulivan force-pushed the document-viewer-local-pdfjs branch from 27561ca to 6d4485d Compare August 19, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants