-
Notifications
You must be signed in to change notification settings - Fork 83
feat: Improve button UX #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR significantly refactors and improves the button user experience by implementing a comprehensive theme system, creating reusable button components, and streamlining the codebase architecture. The changes introduce light/dark theme support, a new button component system, and improved code organization through better separation of concerns.
Key Changes:
- Implemented comprehensive theme system with light/dark mode support and automatic theme detection
- Created reusable button component with consistent styling and state management across platforms
- Refactored content scripts to use the new component system and improved search session management
Reviewed Changes
Copilot reviewed 24 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/util_functions.ts | Replaced hardcoded URL with API constant and improved type imports |
| src/utils/ui/button_theme.ts | New theme system with comprehensive color schemes for light/dark modes |
| src/utils/theme.ts | Theme detection and change handling utilities |
| src/types/memButton.ts | Type definitions for the new button component system |
| src/types/chrome.ts | Chrome extension API type extensions |
| src/types/browser.ts | Browser type definitions moved from util_functions.ts |
| src/types/background_search.ts | Background search types extracted from utils |
| src/types/memory.ts | Added new memory prompt fields for rerank system |
| src/sidebar.ts | Updated API URLs to use constants instead of hardcoded strings |
| src/replit/content.ts | Complete rewrite using new button system and improved architecture |
| src/popup.ts | Updated to use API constants |
| src/mem0/content.ts | Updated API URLs to use constants |
| src/grok/content.ts | Complete rewrite using new button system and search session management |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Description
I've implemented new version of button to simplify the user experience. Also, I've made some code refactoring.
Works done
To test this version without building