The NHC_RM must be exported to the ONLINE_NODE/OFFLINE_NODE scripts #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With NHC 1.5 we get an error in nhc.log when on/offlining a Slurm node:
20250827 13:21:51 [] /usr/libexec/nhc/node-mark-online x007
/usr/libexec/nhc/node-mark-online: Unsupported RM detected in /usr/libexec/nhc/node-mark-online: ""
In fact nhc correctly autodetects NHC_RM=slurm but never exports that variable to the ONLINE_NODE/OFFLINE_NODE scripts.
A workaround is to export NHC_RM in nhc.conf as suggested by many people:
However, the correct fix appears to be exporting NHC_RM in nhc as proposed in this PR.