Skip to content

fix: reverse is not doing great in Arabic #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: reverse is not doing great in Arabic #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49277b8
🐛 fix: Fixed Arabic display issue. closes #295
kingmui Feb 14, 2025
b774ed5
🐛 fix: Can't click pause on mobile device
kingmui Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions packages/playground/vite-project/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,24 @@
</p>

<div style="display: flex">
<Vue3Marquee :duration="7" direction="reverse">
نفس إحكام الإنذار، لم, فبعد وحل الأثنان. هو تصفح بالرّغم مك|هو
<Vue3Marquee
:direction="isRTL ? 'reverse' : 'normal'"
:delay="2"
:duration="5"
animate-on-overflow-only
pause-on-hover
pause-on-click
>
<span
v-for="(item, index) in arabicList"
:key="index"
:style="isRTL ? 'margin-left: 48px' : 'margin-right: 48px'"
>
{{ `${index + 1}. ${item}` }}
</span>
</Vue3Marquee>
</div>
<button @click="handleToggleDirection">Toggle text direction</button>
</div>

<div v-if="showAll">
Expand Down Expand Up @@ -230,9 +244,20 @@ export default defineComponent({
playState: false,
showAll: false,
toggleShow: true,
isRTL: false,
arabicList: ['علوم الفضاء والتكنولوجيا', 'المهمات الفضائية', 'أكاديمية الفضاء الوطنية', 'تنظيم الفضاء', 'البرامج الفضائية'],
}
},
methods: {
handleToggleDirection() {
const _documentElement = document.documentElement
const dir = _documentElement.getAttribute('dir')

const _isRTL = dir === 'rtl'

_isRTL ? _documentElement.removeAttribute('dir') : _documentElement.setAttribute('dir', 'rtl')
this.isRTL = !_isRTL
},
generateRandomString() {
const randomString = Math.random().toString(36).substring(2, 15)
return `https://api.dicebear.com/7.x/adventurer/svg/seed=${randomString}`
Expand Down
22 changes: 18 additions & 4 deletions packages/vue3-marquee/src/vue3-marquee.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
@mouseleave="hoverEnded"
@mousedown="mouseDown"
@mouseup="mouseUp"
@touchstart="mouseDown"
@touchend="mouseUp"
>
<div
class="transparent-overlay"
Expand Down Expand Up @@ -158,6 +160,8 @@ export default defineComponent({
],

setup(props, { emit }) {
const isMobile = 'ontouchstart' in document.documentElement

const cloneAmount = ref(0)

const minWidth = ref('100%')
Expand Down Expand Up @@ -301,15 +305,15 @@ export default defineComponent({
)

const hoverStarted = () => {
if (props.pauseOnHover) {
if (!isMobile && props.pauseOnHover) {
emit('onPause')

mouseOverMarquee.value = true
}
}

const hoverEnded = () => {
if (props.pauseOnHover) {
if (!isMobile && props.pauseOnHover) {
emit('onResume')

mouseOverMarquee.value = false
Expand Down Expand Up @@ -513,6 +517,16 @@ export default defineComponent({
</script>

<style>
:root {
--scroll-start: 0%;
--scroll-end: -100%;
}

html[dir='rtl'] {
--scroll-start: 100%;
--scroll-end: 0%;
}

.vue3-marquee {
display: flex !important;
position: relative;
Expand Down Expand Up @@ -565,10 +579,10 @@ export default defineComponent({

@keyframes scrollX {
0% {
transform: translateX(0%);
transform: translateX(var(--scroll-start));
}
100% {
transform: translateX(-100%);
transform: translateX(var(--scroll-end));
}
}

Expand Down