Get version from image - must-gather #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HOLD. Wait for a response after we have opened a discussion in ECOPROJECT-983 about possible bug in default OCP must-gather https://coreos.slack.com/archives/CFDM5CQMN/p1661184777988329 Maybe openshift/must-gather#327 would resolve https://issues.redhat.com/browse/ECOPROJECT-982 without the need for this PR. |
razo7
force-pushed
the
version-file-must-gather
branch
from
92c0b1a to
c27f164
Compare
|
Similar fix to a similar bug ECOPROJECT-983 |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the must-gather enhancement, there is a version file that indicates the product (first line) and the version (second line).
Currently the printed version is only in y.z format, due to regular expression, when y and z are one digit each. Resulting in "0.4" version for
https://registry.redhat.io/workload-availability/self-node-remediation-must-gather-rhel8:v0.4.0, rather than "0.0.4".Fix bug https://issues.redhat.com/browse/ECOPROJECT-982