Feature/rename mock data files #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo in layout index
* master: (186 commits) Fix support for import! in _variables.yaml Update muban-core to 2.1.2 and typescript to 3.8.3 Align 3.2.0 muban Bump websocket-extensions from 0.1.3 to 0.1.4 Replace httpEquiv with http-equiv Remove slashes Remove slash Sync viewport meta tag between templates Add AEM clientlib generator to build script add seng generator as a local dependency (mediamonks#123) upgrade node-sass to latest version Update path to data for blocks added through generator tool (mediamonks#116) Replace tabs with spaces (mediamonks#115) Create folder for data files in generator templates (mediamonks#103) rename btn to button since we should not use abbreviations remove disabling of style lint rule by default add the keyword 'public' and 'readonly' for static displayName Update existing code to match new tslint rule for member access set tslint rule `member-access` to true, so it requires explicit visibility declarations for class members. Override singleQuote option for SCSS files (mediamonks#106) ...
|
Somehow there are commits from 2018 in this PR, how did that happen? Could you squash into a single commit, and force-push? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the changes from this PR:
#137
I removed the -data from the names.