-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update Safari data for ExtendableCookieChangeEvent API #27789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
queengooborg
wants to merge
1
commit into
mdn:main
Choose a base branch
from
queengooborg:api/ExtendableCookieChangeEvent/safari-corrections
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−6
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to repeat the flags on the subfeatures?
In #27726, I asked for these to be removed. If the interface is behind a flag, all the subfeatures are implicitly behind that flag as well, aren't they? Similarly, if a parent feature is only implemented with an alternative name, we don't specify the alternative name on the subfeatures (it would be misleading).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should be propagating the flag data down to subfeatures.
Unlike prefixes or alternative names, flags apply directly to the subfeatures as well. By copying the data down to subfeatures, it allows consumers to understand that a flag must be enabled for the feature, even if they're looking at a small scope such as a single method or property.
Another benefit of copying the flag data down to subfeatures (and not in a build step) is that it makes it easier for tooling, such as the collector, to update this data once the flag's been enabled by default. In fact, it was actually due to the collector tests that the lack of default support was detected!
While the collector could be updated to account for parent flag data, based upon my understanding of the way the new update script works, that would involve a complete rewrite. Either that, or a whole list of results overrides would have to be maintained!