Issue #531: Email task performance improvements and time limit #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peterburnett
force-pushed
the
issue531-402
branch
2 times, most recently
from
84520d8 to
31c296f
Compare
Peterburnett
force-pushed
the
issue531-402
branch
from
31c296f to
8cb3dab
Compare
|
Hi @mdjnelson, just checking in on this one, and if you had any feedback. I can deploy on a fork, but I would rather not where it can be avoided. It would be ideal if I could include this in my next client deployment in 2-3 weeks |
|
Sorry @Peterburnett i've been focusing on other issues and am free to look now. Also, please see there is another improvement for this at #610. Feel free to have a look and comment with what you think. :) |
|
Hi Peter, I don't think it is safe to assume just because the user accessed the course after the last time the task was run that they would have necessarily downloaded the certificate. What are your thoughts? |
|
Closing this in favour of #610 and due to my comments above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #531