Skip to content

✨ feat: add custom hitboxes and rework related modules #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aksiome
Copy link
Member

@aksiome aksiome commented Jun 8, 2025

Description

This PR introduces a major overhaul to how hitboxes are defined and handled in Bookshelf. Given the size and impact of this update, a thorough review and additional testing are needed.
Even though this is still a draft, @theogiraudet, I'd appreciate an early review of the API design. If anything feels unclear, misnamed, or could be improved from a usability or consistency standpoint, please flag it.

Related Issues

Additional Notes

Remaining tasks:

  • Update the changelog (mark deprecated elements clearly)
  • Rework hitbox check functions to use the new system and update docs accordingly
  • Check feature metadata update date

Tasks to complete before merging

  • I agree to release my contribution under the MPL v2 License.
  • My pull request is associated with an existing issue.
  • I have updated the changelog to reflect my contribution.
  • If this pull request adds or modifies a feature:
    • I have documented my changes in the /docs folder.
    • I have updated the metadata of the feature. See feature metadata.
    • I have thoroughly tested my changes. See testing guidelines.

@aksiome aksiome requested a review from theogiraudet June 8, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant