-
Notifications
You must be signed in to change notification settings - Fork 29
Several tweaks to the CI and testing configurations #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This looks great, thank you! I meant to get around to 2, but clearly hadn't. |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 79.98% 81.25% +1.26%
==========================================
Files 18 18
Lines 1684 1686 +2
==========================================
+ Hits 1347 1370 +23
+ Misses 337 316 -21
Continue to review full report at Codecov.
|
I'm going to change this to draft until I can get CI to pass. |
There might be more fiddling around with VectorizationBase things required from my side, which didn't make it into #53. |
I think I have all the VectorizationBase stuff working now. Let's see if it passes on CI. |
There's a lot of "queued" jobs. You can go to https://github.com/mcabbott/Tullio.jl/actions?query=workflow%3ACI and https://github.com/mcabbott/Tullio.jl/actions?query=workflow%3A%22CI+%28Julia+nightly%29%22 and cancel all but the most recent job. |
FWIW, where there commented out # Mask{UInt8}(0x02) The proper constructor would be |
I was confused for a bit! Cleaned up a bit locally but... well now I made #57. |
This is good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep testing on 1.4, and LoopVectorization 0.8. But there's going to be some massaging to make this and #57 fit no matter what we do... so perhaps simplest to merge this & then work on top of it.
Let me play around with this a bit and see if that's possible |
Alright, I've made some changes. We will keep running CI on Julia 1.4. On 1.4 CI we'll use LoopVectorization 0.8, and on 1.5 CI we'll use LoopVectorization 0.9. I'll keep this as a draft until all of the CI jobs pass. |
@mcabbott Alright, take a look now. CI is passing on Julia 1.4 and Julia 1.5. So this should be ready to go. We test on both Julia 1.4 and Julia 1.5. On Julia 1.4, we test with LoopVectorization 0.8, and on Julia 1.5 we test with LoopVectorization 0.9. |
Thanks, this looks good, and well beyond the call of duty! I have one last question, which I didn't notice earlier. All of them seem to show (6 is ideal for tests, as |
Oof that's my mistake. I have a mistake in the workflow file. |
Yeah it looks like GitHub will also only give us two threads. From https://github.com/mcabbott/Tullio.jl/pull/55/checks?check_run_id=1552071969
|
But at least now the tests are running with different numbers of threads (one or two). |
Closes #39
This pull request makes the following modifications to the CI configuration:
continue-on-error
. Withcontinue-on-error
, it becomes very easy to fail to notice when your CI fails on Julia nightly. In contrast, the approach in this PR allows you to notice when CI fails on Julia nightly, while still having a green "Passing" CI badge in your README even if CI fails on Julia nightly.[compat]
entries for all of the test-only dependencies.