Skip to content

Conversation

@afedor
Copy link

@afedor afedor commented Jul 12, 2024

  • Convert to utf8 before writing string so string and string length match

- Convert to utf8 _before_ writing string so string and string length match
@WollZebra
Copy link
Collaborator

Nice finding. Looks good to me.
Did you find a unit test that checks what was written into the stream?
QDataStream &s

@afedor
Copy link
Author

afedor commented Nov 27, 2024

That's not very easy since this encoding is only used for some 'metadata', like routing keys and queue names. So if it's not encoded correctly, you end up just not receiving a message at all, since the routing key doesn't match. That's what my test checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants