Fix: No comma when locality is empty (small fix) #2111
Merged
+41
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LEstradioto So "proper" for a one-liner would actually be a comma after the street name as well.
|
|
Great, thanks. Address string will now follow the I18n formatting and as a one-liner |
|
Merged. Thanks so much, @LEstradioto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when Properties have empty address it shows a single comma on subtitle
This PR pushes a fix for that, when no Locality is saved, there is no comma
And, perhaps, another fix could be added here.
It seems i18n format should supposed be shown like right side of image? If so, I could just update that too.