Skip to content

fix: prevent content overflow in transaction modal by enabling internal scrolling #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prevent content overflow in transaction modal by enabling internal scrolling #2101

wants to merge 2 commits into from

Conversation

the-spectator
Copy link
Contributor

Before:

Screen.Recording.2025-04-13.at.6.04.33.PM.mov

After:

Screen.Recording.2025-04-13.at.6.01.21.PM.mov

zachgoll
zachgoll reviewed Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here. This modal partial is used in several places across the app. Would you mind doing a quick check to make sure this doesn't introduce any UI regressions elsewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachgoll zachgoll zachgoll left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-spectator @zachgoll