-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Feature: Mobile responsiveness #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LEstradioto
wants to merge
29
commits into
maybe-finance:main
Choose a base branch
from
LEstradioto:mobile-responsiveness
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature: Mobile responsiveness #2081
LEstradioto
wants to merge
29
commits into
maybe-finance:main
from
LEstradioto:mobile-responsiveness
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed background color of the mobile navigation bar to 'bg-surface'. - Adjusted breadcrumb navigation to be hidden on smaller screens. - Modified padding in sidebar navigation items for better alignment. - Enhanced balance sheet display by appending total assets/liabilities to the classification group title. - Progress Pills implemented on mobile
…wind v4 update previously) - Deleted the notification partial as it seems not used
…ight, better charts mobile responsiveness
- New button modifier, fix layout dashboard and transaction - Search form with mobile-specific placeholder text and filter - Transaction summary adapt to different screen sizes - Added a Responsive Attribute Stimulus Controller: Change any attribute by breakpoint
- Tab and Icon mobile sizes - Transaction listing and forms adapted to different screen sizes - Added responsive to selection bar - Ensure full-screen to bulk edit and drawer
- Mobile nav header on import views - Updated select field styling with Stimulus controller for dynamic class changes based on value (like input placeholder) - Adjusted layout for import configurations and tables - Updated some placeholder text
- Added helper methods to tab switch. - Update views to follow Figma files. - Updated donut chart controller to conditionally render based on the actuals tab.
…ow when clicked. - Add mobile-only Buttons - Added height to the scrollbar - Updated settings navigation to include icons - Added a nice Preserve Scroll logic, applied on Mobile menu - Categories color picker is okay on mobile, need enhance on Tablet
10719d2
to
53e0f28
Compare
…he mobile menu. - Updated sidebar navigation item icon for Assistant - Adjusted CSS classes for active state in sidebar navigation
- Updated user_params to remove password confirmation from permitted params - Disabled default password validations in User model, added custom validations for password strength. - Improved password input fields in registration forms with strength indicators and toggle visibility. - Adjusted layout in authentication views for better alignment and user experience.
Hi there. Ive finished. There is a lot to show, but here is a video showcasing everything. mobile_responsiveness.mp4 |
@Shpigford I appreciate a review on this too! |
5 tasks
…ile image preview functionality, and adjust layout for mobile responsiveness in various views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #2077
Hi, Im working on this,
opening as draft, as it will have lots of changing.SOME NOTES
Figma presents an Abbreviated display on Assets money. Like the image:Perhaps this should be implemented in another PR. Because it should handle i18n/intl properly, for Totals like 1.5B, 100M or 100K. For now, I just displayed without abbrev.Implemented the abbreviation system (but just like the current format method, not with extensive i18n support)
I couldnt see some features, like “Export transactions”,
“Download a CSV example?” (at import view), “That AI thing on CSV” (at import view).So I just ignored those.Download CSV sample is implemented.
Could implement Export and AI csv helper, but... since this will have a lot of changing, and breaking tests probably. Better do on another PR. Just let me know if you need it in this scope.
I will keep a TODO to stay organized: