Skip to content

Feature: Mobile responsiveness #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

LEstradioto
Copy link
Contributor

@LEstradioto LEstradioto commented Apr 11, 2025

/claim #2077

Hi, Im working on this, opening as draft, as it will have lots of changing.


SOME NOTES

  • Some texts are not the same from Current Design and Figma. So, Ive decided on my own between the options. If needed I could just change it.
  • I pointed this Help Button on mobile sidebar to Contact (intercom)

image

  • Figma presents an Abbreviated display on Assets money. Like the image:

image

Perhaps this should be implemented in another PR. Because it should handle i18n/intl properly, for Totals like 1.5B, 100M or 100K. For now, I just displayed without abbrev.

  • Implemented the abbreviation system (but just like the current format method, not with extensive i18n support)

  • I couldnt see some features, like “Export transactions”, “Download a CSV example?” (at import view), “That AI thing on CSV” (at import view). So I just ignored those.

  • Download CSV sample is implemented.

  • Could implement Export and AI csv helper, but... since this will have a lot of changing, and breaking tests probably. Better do on another PR. Just let me know if you need it in this scope.


I will keep a TODO to stay organized:

  • Finished SIGN IN/SIGN UP, ONBOARDING, HOME, Notifications, Sidebar – Accounts, ADD ACCOUNT FLOW, Transactions VIEW + Transaction detail view + New transaction, Import transactions, Budgeting view, Settings view
  • Assistant Views
  • Shared (Activity / Overview views)
  • Add a Sign in / Sign up switcher at mobile

- Changed background color of the mobile navigation bar to 'bg-surface'.
- Adjusted breadcrumb navigation to be hidden on smaller screens.
- Modified padding in sidebar navigation items for better alignment.
- Enhanced balance sheet display by appending total assets/liabilities to the classification group title.
- Progress Pills implemented on mobile
…wind v4 update previously)

- Deleted the notification partial as it seems not used
- New button modifier, fix layout dashboard and transaction
- Search form with mobile-specific placeholder text and filter
- Transaction summary adapt to different screen sizes
- Added a Responsive Attribute Stimulus Controller: Change any attribute by breakpoint
- Tab and Icon mobile sizes
- Transaction listing and forms adapted to different screen sizes
- Added responsive to selection bar
- Ensure full-screen to bulk edit and drawer
- Mobile nav header on import views
- Updated select field styling with Stimulus controller for dynamic class changes based on value (like input placeholder)
- Adjusted layout for import configurations and tables
- Updated some placeholder text
- Added helper methods to tab switch.
- Update views to follow Figma files.
- Updated donut chart controller to conditionally render based on the actuals tab.
…ow when clicked.

- Add mobile-only Buttons
- Added height to the scrollbar
- Updated settings navigation to include icons
- Added a nice Preserve Scroll logic, applied on Mobile menu
- Categories color picker is okay on mobile, need enhance on Tablet
@LEstradioto LEstradioto force-pushed the mobile-responsiveness branch from 10719d2 to 53e0f28 Compare April 11, 2025 22:30
…he mobile menu.

- Updated sidebar navigation item icon for Assistant
- Adjusted CSS classes for active state in sidebar navigation
- Updated user_params to remove password confirmation from permitted params
- Disabled default password validations in User model, added custom validations for password strength.
- Improved password input fields in registration forms with strength indicators and toggle visibility.
- Adjusted layout in authentication views for better alignment and user experience.
@LEstradioto
Copy link
Contributor Author

Hi there. Ive finished.

There is a lot to show, but here is a video showcasing everything.

mobile_responsiveness.mp4

@LEstradioto LEstradioto marked this pull request as ready for review April 12, 2025 03:19
@LEstradioto
Copy link
Contributor Author

@Shpigford I appreciate a review on this too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant