Add wrapper for char arrays to access str conveniently #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a wrapper around char arrays that allows to access them either as slices or as strings. When accessing the string representation, it will automatically convert the char array to a string slice up to the first null byte.
|
I will try to allocate sometime at Sunday to review this. |
onur-ozkan
reviewed
Aug 31, 2025
Comment on lines
+23
to
+26
| #[derive(Debug, PartialEq, Clone, Copy)] | ||
| #[cfg_attr(feature = "serde", derive(Serialize))] | ||
| #[cfg_attr(feature = "serde", serde(transparent))] | ||
| pub struct CharArray<const N: usize> { |
There was a problem hiding this comment.
Suggested change
| #[derive(Debug, PartialEq, Clone, Copy)] | |
| #[cfg_attr(feature = "serde", derive(Serialize))] | |
| #[cfg_attr(feature = "serde", serde(transparent))] | |
| pub struct CharArray<const N: usize> { | |
| #[cfg_attr(feature = "serde", derive(Serialize))] | |
| #[cfg_attr(feature = "serde", serde(transparent))] | |
| #[derive(Debug, PartialEq, Clone, Copy)] | |
| pub struct CharArray<const N: usize> { |
Comment on lines
+57
to
+60
| /// Returns the string stopping at the first null byte and if the string is not valid utf8 | ||
| /// the returned string will be empty. | ||
| pub fn to_str(&self) -> &str { | ||
| core::str::from_utf8(&self.data[..self.str_len]).unwrap_or("") |
There was a problem hiding this comment.
Why is that we return empty string if the value is invalid? I think the caller should decide what to do on invalid UTF8 values. We can simply return the inner Result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #370
This adds a wrapper around char arrays that allows to access them either as slices or as strings. When accessing the string representation, it will automatically convert the char array to a string slice up to the first null byte.
A part I have some slight doubts about is the serde derives on the
CharArray<N>struct. If someone could validate that this is correct that would be great.