Skip to content

Conversation

HTRamsey
Copy link
Collaborator

@HTRamsey HTRamsey commented Sep 16, 2025

Try using Haswell arch for macos

@HTRamsey HTRamsey requested a review from Copilot September 16, 2025 11:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes deployment adjustments for Linux and macOS builds to address compatibility issues. The changes focus on updating architecture specifications and improving library dependencies for better platform support.

  • Updates macOS universal build to use Haswell architecture (x86_64h) instead of standard x86_64
  • Adds newer GCC toolchain repository and libstdc++6 package for ARM build compatibility
  • Fixes YAML formatting in the macOS workflow configuration

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/setup/install-dependencies-debian.sh Adds Ubuntu toolchain PPA and libstdc++6 package for improved ARM compatibility
cmake/Toolchain.cmake Updates commented architecture detection logic to include x86_64h
cmake/CustomOptions.cmake Changes universal build description to reflect x86_64h architecture
CMakeLists.txt Updates macOS universal build to use x86_64h instead of x86_64
.github/workflows/macos.yml Fixes YAML line continuation formatting in configure step

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@HTRamsey HTRamsey force-pushed the dev-linux-macos-deployment branch 3 times, most recently from 1836507 to 2300eaf Compare September 24, 2025 12:18
@HTRamsey HTRamsey force-pushed the dev-linux-macos-deployment branch from 2300eaf to 398b71f Compare September 25, 2025 06:25
@HTRamsey HTRamsey changed the title Minor Adjustments to Linux & MacOS Deployment MacOS: Use x86_64h Architecture Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant