Skip to content

Remote ID: Fix zero and negative GCS GPS altitude being invalid #13378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −1
Open

Remote ID: Fix zero and negative GCS GPS altitude being invalid #13378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48b1875
Remote ID: Negative GCS GPS altitude can be valid. NaN GCS GPS altitu…
jnomikos Sep 12, 2025
eb257ab
qIsNaN, fix reversed logic
jnomikos Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Vehicle/RemoteIDManager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ void RemoteIDManager::_sendSystem()
// GPS position needs to be valid before checking other stuff
if (geoPositionInfo.isValid()) {
// If we dont have altitude for FAA then the GPS data is no good
if ((_settings->region()->rawValue().toInt() == Region::FAA) && !(gcsPosition.altitude() >= 0) && _gcsGPSGood) {
if ((_settings->region()->rawValue().toInt() == Region::FAA) && qIsNaN(gcsPosition.altitude()) && _gcsGPSGood) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NaN check makes sense except for the fact that PositionManager will never set altitude to NaN. The reason your code remove the flicker is because of this fact. Or in other words qIsNaN(gcsPosition.altitude() will always be false.

The PositionManager code needs to be updated to use NaN for value not available for lat/lon/altitude/heading. And then all the code that references PositionManager gcs position/heading needs to be checked to handle unavailable values.

Can you take a look at doing that as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the info, will look into it. Might be in a few weeks because I have a lot on my plate and will be moving all next week

_gcsGPSGood = false;
emit gcsGPSGoodChanged();
qCDebug(RemoteIDManagerLog) << "GCS GPS data error (no altitude): Altitude data is mandatory for GCS GPS data in FAA regions.";
Expand Down
Loading