fix(windows): improve crash handling to prevent process hanging #13306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace std::terminate() with TerminateProcess() for immediate process termination - Set Windows error mode to suppress system error dialogs - Use SetUnhandledExceptionFilter to catch all unhandled exceptions - Comment out AddVectoredExceptionHandler (keeping as reference) - Ensure crashed processes exit cleanly without hanging in background This resolves issues where crashed applications would remain as zombie processes that couldn't be terminated by task manager. Fixes: Program crashes but hangs in background instead of exiting
|
Nice, was working on that here but just didn't get to finish. I'll probably add yours first then just move it to the new file I created in my PR |
|
@HTRamsey You can consider generating a dmp file when a crash occurs. I haven't figured out how to add this feature yet. |
|
I went ahead and merged my other PR that included this. If you want to make any changes to what I did please feel free |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the crash handling mechanism on Windows platform to prevent applications from hanging in the background after crashes, which previously required manual termination through task manager.
Changes made:
SetErrorMode()to suppress system error dialogs (SEM_NOGPFAULTERRORBOX,SEM_FAILCRITICALERRORS,SEM_NOOPENFILEERRORBOX)SetUnhandledExceptionFilter()withTerminateProcess()for immediate process terminationTest Steps
Before: Crashed applications would hang in background, requiring manual termination via task manager
After: Crashed applications terminate immediately and cleanly
Related Issue
This addresses the issue where crashed applications on Windows would remain as hanging processes that couldn't be terminated by task manager, requiring forced termination through system tools.
Problem: Program crashes but hangs in background instead of exiting cleanly
Solution: Direct process termination using Windows API without relying on potentially corrupted Qt event loops