Windows: Remove Driver Installer #13276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes Windows driver installer functionality from the QGroundControl installer, as these drivers are no longer needed on Windows 10/11 systems.
- Eliminates automatic UAV driver installation during setup
- Removes driver download logic and related CMake configuration
- Simplifies Windows installer by removing driver version checks and installation flow
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| deploy/windows/nullsoft_installer.nsi | Removes 32-bit uninstaller check, driver installation logic, and driver version management |
| deploy/windows/driver-msi-README.md | Deletes file explaining driver.msi source |
| cmake/platform/Windows.cmake | Removes commented driver download configuration |
| cmake/install/Install.cmake | Removes driver MSI path variable definition |
| cmake/install/CreateWinInstaller.cmake | Removes driver MSI parameter from NSIS installer |
| cmake/install/CreateQGCInstaller.cmake | Removes driver download logic and fixes conditional block |
HTRamsey
force-pushed
the
dev-windows-drivers
branch
12 times, most recently
from
a2e27b9 to
5d308e1
Compare
HTRamsey
force-pushed
the
dev-windows-drivers
branch
from
5d308e1 to
0701616
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These shouldn't be needed on Windows 10/11 - maybe we just provide a minimal driver set instead. Would rather not rely on an external source for these
Edit: Tested & Win11 works without external drivers