Skip to content

Conversation

Pedro-Roque
Copy link
Contributor

@Pedro-Roque Pedro-Roque commented Jul 24, 2025

Spacecraft Support

Description

Adds support for Spacecraft vehicles, currently being available in PX4, ATMOS.

Test Steps

Build PX4 SITL with

make px4_sitl_spacecraft gz_atmos

Open this build, go to vehicle configuration, PID Tuning. Rejoice!
Also added image and airframe_group for spacecraft.

Checklist:

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Screenshots

image image

@Pedro-Roque Pedro-Roque marked this pull request as ready for review July 25, 2025 00:37
@Pedro-Roque
Copy link
Contributor Author

@DonLakeFlyer can we get this one through?

@DonLakeFlyer
Copy link
Contributor

I think this should be also added as a new Vehicle Class in QGCMAVLink.* code. Also what about bool PX4FirmwarePlugin::isCapable(const Vehicle *vehicle, FirmwareCapabilities capabilities) const? Should any capability bits be set?

@DonLakeFlyer
Copy link
Contributor

Does this vehicle support missions?

@Pedro-Roque
Copy link
Contributor Author

Does this vehicle support missions?

I did not try missions with this vehicle. So far it is experimental. Would this need to be support for QGC?

@Pedro-Roque
Copy link
Contributor Author

capabilities

Will check this out.

@DonLakeFlyer
Copy link
Contributor

@Pedro-Roque Any updates here?

@Pedro-Roque
Copy link
Contributor Author

Hi @DonLakeFlyer not yet, but I'll come back to you before the weekend. Sorry for the delay, things are a bit hectic atm

@Pedro-Roque
Copy link
Contributor Author

@DonLakeFlyer finally got to do it. No extra capabilities should be added at this point, this will be for later. The vehicle does not support missions for now.

I also fixed a string for proper text spacing on the Airframe tab.

@Pedro-Roque
Copy link
Contributor Author

@DonLakeFlyer just checking if there is anything else I should do before we merge this in.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for spacecraft vehicles in QGroundControl, specifically for PX4 SITL with the ATMOS spacecraft simulator. The implementation includes vehicle classification, PID tuning components, and UI elements for spacecraft configuration.

Key changes:

  • Adds spacecraft vehicle type classification with MAV_TYPE_SPACECRAFT_ORBITER
  • Implements PID tuning UI components for spacecraft rate, attitude, velocity, and position control
  • Adds spacecraft airframe configuration and visual assets

Reviewed Changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
Vehicle.h/.cc Adds spacecraft() method for vehicle type detection
QGCMAVLink.h/.cc Implements spacecraft classification and string conversion functions
PX4TuningComponent*.qml Creates PID tuning UI components for spacecraft control loops
PX4TuningComponent.cc Adds spacecraft case to tuning component selection
AirframeFactMetaData.xml Defines spacecraft airframe configuration
qgcimages.qrc Adds FreeFlyer.svg image resource for spacecraft

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DonLakeFlyer
Copy link
Contributor

DonLakeFlyer commented Aug 31, 2025

@Pedro-Roque Can you look at the CoPilot comments? I looked at the SC_YAWRATE_D param and the "D" represents "differential" so the complaints may be correct.

@Pedro-Roque
Copy link
Contributor Author

@DonLakeFlyer fixed!

@DonLakeFlyer
Copy link
Contributor

OK, so theoretically be good to go now. Can you squash to single commit?

@Pedro-Roque
Copy link
Contributor Author

@DonLakeFlyer sure, but feel free to squash merge this with the commit message "feat: spacecraft-orbitter support"

@Pedro-Roque
Copy link
Contributor Author

@DonLakeFlyer are we good to merge this in?

@DonLakeFlyer
Copy link
Contributor

Gonna do another Ci run to verify

@Pedro-Roque
Copy link
Contributor Author

Looks good @DonLakeFlyer

@DonLakeFlyer DonLakeFlyer merged commit b7dd912 into mavlink:master Sep 16, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants