-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat: spacecraft support #13214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spacecraft support #13214
Conversation
@DonLakeFlyer can we get this one through? |
I think this should be also added as a new Vehicle Class in QGCMAVLink.* code. Also what about |
Does this vehicle support missions? |
I did not try missions with this vehicle. So far it is experimental. Would this need to be support for QGC? |
Will check this out. |
@Pedro-Roque Any updates here? |
Hi @DonLakeFlyer not yet, but I'll come back to you before the weekend. Sorry for the delay, things are a bit hectic atm |
…ontrol into dev-spacecraft_support
@DonLakeFlyer finally got to do it. No extra capabilities should be added at this point, this will be for later. The vehicle does not support missions for now. I also fixed a string for proper text spacing on the Airframe tab. |
@DonLakeFlyer just checking if there is anything else I should do before we merge this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for spacecraft vehicles in QGroundControl, specifically for PX4 SITL with the ATMOS spacecraft simulator. The implementation includes vehicle classification, PID tuning components, and UI elements for spacecraft configuration.
Key changes:
- Adds spacecraft vehicle type classification with MAV_TYPE_SPACECRAFT_ORBITER
- Implements PID tuning UI components for spacecraft rate, attitude, velocity, and position control
- Adds spacecraft airframe configuration and visual assets
Reviewed Changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
Vehicle.h/.cc | Adds spacecraft() method for vehicle type detection |
QGCMAVLink.h/.cc | Implements spacecraft classification and string conversion functions |
PX4TuningComponent*.qml | Creates PID tuning UI components for spacecraft control loops |
PX4TuningComponent.cc | Adds spacecraft case to tuning component selection |
AirframeFactMetaData.xml | Defines spacecraft airframe configuration |
qgcimages.qrc | Adds FreeFlyer.svg image resource for spacecraft |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/AutoPilotPlugins/PX4/PX4TuningComponentSpacecraftPosition.qml
Outdated
Show resolved
Hide resolved
src/AutoPilotPlugins/PX4/PX4TuningComponentSpacecraftPosition.qml
Outdated
Show resolved
Hide resolved
@Pedro-Roque Can you look at the CoPilot comments? I looked at the SC_YAWRATE_D param and the "D" represents "differential" so the complaints may be correct. |
…ontrol into dev-spacecraft_support
@DonLakeFlyer fixed! |
OK, so theoretically be good to go now. Can you squash to single commit? |
@DonLakeFlyer sure, but feel free to squash merge this with the commit message "feat: spacecraft-orbitter support" |
@DonLakeFlyer are we good to merge this in? |
Gonna do another Ci run to verify |
Looks good @DonLakeFlyer |
Spacecraft Support
Description
Adds support for Spacecraft vehicles, currently being available in PX4, ATMOS.
Test Steps
Build PX4 SITL with
Open this build, go to vehicle configuration, PID Tuning. Rejoice!
Also added image and airframe_group for spacecraft.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Screenshots