'find_all_minima' to include global minima #60
Conversation
|
Thanks! Could you add a test case that checks that the minima is correctly grabbed? This would be similar to the partial VHFs we talked about previously. |
|
Some functions you could try grabbing the minima of: x^2, 2^x, sqrt(x), logit (https://docs.scipy.org/doc/scipy/reference/generated/scipy.special.logit.html). |
rmatsum836
left a comment
rmatsum836
left a comment
There was a problem hiding this comment.
@jacoblumpkins could you also quickly review? Thanks!
| global_min = min(arr) | ||
| global_r = np.where(arr == global_min)[0] | ||
| minima = np.append(minima, global_r) | ||
| minima.sort() |
There was a problem hiding this comment.
If the global minima is also a local minima, would this not create a duplicate entry in the result array? Other than that, this look good
There was a problem hiding this comment.
@lisankim0321 could you double-check this for the x^2 function?
The reason for adding this is that the checks variable on line 60 doesn't correctly capture cases when a curve starts at the global minima and continues to increase as x increases.
3 participants
For better selection of upper and lower bounds of the integral calculation in
get_auc,find_all_minimanow has global minima in the array.