Skip to content

Conversation

0xValera
Copy link
Collaborator

@0xValera 0xValera commented Oct 6, 2025

What ❔

Separate interop relevant changes from #1704.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

Copy link

github-actions bot commented Oct 6, 2025

Coverage after merging vg/sb-server-fixes-cherrypick into kl/medium-interop will be

78.85%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
contracts/bridge
   BridgeHelper.sol100%100%100%100%
   BridgedStandardERC20.sol96.25%100%92.31%97.01%231–232
   L1ERC20Bridge.sol97.78%100%100%97.37%261
   L1Nullifier.sol88.27%100%86.67%88.55%128–129, 181, 190, 414–415, 418, 444, 627, 629, 673, 685, 688, 690, 703, 716–717, 721–722
contracts/bridge/asset-router
   AssetRouterBase.sol98.55%100%100%98.25%122
   L1AssetRouter.sol92.07%100%89.66%92.59%102, 314, 325, 407–408, 428, 586, 597, 611, 616
contracts/bridge/asset-tracker
   AssetTrackerBase.sol66.67%100%63.64%68%54–55, 64–65, 77–78, 81–82
   GWAssetTracker.sol27.48%100%35.48%26.18%105, 109, 112–113, 116–117, 120–121, 124–125, 132–133, 175, 178–179, 182, 184–188, 190, 192, 194–198, 200–201, 203–204, 206–214, 216, 218, 220, 222–224, 229–230, 232–233, 237, 239–240, 246, 253–256, 258–259, 261, 263–267, 269–270, 274–279, 285–286, 289–290, 294–295, 297, 300, 302–303, 305–306, 308–309, 313–314, 317–318, 320–321, 323, 328, 330, 332, 336, 346, 353, 357–359, 361, 369, 375, 377–378, 380–381, 386–387, 389, 394, 396, 400, 406–407, 411, 417–419, 501, 504, 62–64, 69–71, 76–78, 93–95, 97–99
   L1AssetTracker.sol72.55%100%72%72.66%113–115, 118–121, 123–126, 131–133, 146–148, 199, 203–207, 238, 359, 46–47, 58–59, 62–63, 73–76
   LegacySharedBridgeAddresses.sol0%100%0%0%23, 26, 29, 32, 36–41, 43
contracts/bridge/interfaces
   AssetHandlerModifiers.sol75%100%100%66.67%13
contracts/bridge/ntv
   L1NativeTokenVault.sol73.58%100%77.27%72.62%100–102, 149, 153–155, 178–184, 186, 250–251, 253, 264, 266, 270, 91–92
   NativeTokenVaultBase.sol89.33%100%85.71%90%107, 112, 116–117, 150–153, 155–156, 158, 564–565, 569–570
   UpgradeableBeaconDeployer.sol0%100%0%0%15–16, 18, 20–21
contracts/bridgehub
   BridgehubBase.sol74.06%100%76.32%73.56%134–136, 144, 152, 157–159, 166, 184, 222–223, 229–230, 239, 252–254, 256–257, 259, 261, 293, 296, 315, 331, 362, 400–401, 508, 512, 516–517, 536, 539, 595, 599, 602, 637–638, 642–643, 651–652, 656–657
   CTMDeploymentTracker.sol73.47%100%81.82%71.05%107, 111, 115, 140, 144–145, 33, 41, 66, 79–80
   ChainAssetHandlerBase.sol57.73%100%50%59.04%103–105, 110–112, 133–135, 141–144, 147–148, 199, 202, 214–215, 270, 287, 345, 349, 351, 353–354, 363–364, 368–369, 82, 89–90, 98
   ChainRegistrationSender.sol88.24%100%100%85.19%41, 85, 89, 95
   L1Bridgehub.sol89.42%100%92.31%89.01%100, 217, 292, 296–297, 300, 310, 66–67, 87
   L1ChainAssetHandler.sol81.25%100%75%83.33%42–43, 58–59
   L1MessageRoot.sol60.98%100%85.71%55.88%51–52, 56–58, 61–62, 67–68, 73–74, 78–79, 94–95
   L2Bridgehub.sol47.83%100%40%50%105–106, 114, 116–117, 126, 131–132, 134–135, 47, 49–52, 78, 91–92
   L2ChainAssetHandler.sol73.53%100%66.67%76%47–48, 67–68, 74, 98
   L2MessageRoot.sol75.51%100%72.73%76.32%103, 49–50, 53, 60, 65–66, 90–91
   MessageRootBase.sol82.58%100%95%80.36%105–108, 110–111, 113, 117, 123–125, 133, 150, 160, 165, 170, 172–173, 230, 246, 319, 344
contracts/common
   MessageVerification.sol94.12%100%87.50%96.15%142
   ReentrancyGuard.sol95%100%100%94.12%79
contracts/common/l2-helpers
   L2ContractHelper.sol84.91%100%100%82.22%102, 108, 112, 129, 134, 73, 79, 83
   SystemContractsCaller.sol52.50%100%60%51.43%44–45, 47, 49, 51, 53, 66, 69, 72, 75, 78, 83, 89, 91, 93, 96, 98
contracts/common/libraries
   DataEncoding.sol84.21%100%88.24%83.33%112–113, 120–121, 166, 180, 208, 216–217, 228, 242, 253, 48
   DynamicIncrementalMerkle.sol81.03%100%85.71%80.39%143–146, 148–151, 153–154
   DynamicIncrementalMerkleMemory.sol98.96%100%100%98.84%196
   FullMerkle.sol100%100%100%100%
   FullMerkleMemory.sol85.86%100%100%84.78%114, 131, 149, 163, 89–98
   Merkle.sol98.15%100%100%97.96%83
   MessageHashing.sol96%100%100%95.38%118, 135, 154
   SemVer.sol100%100%100%100%
   UncheckedMath.sol100%100%100%100%
   UnsafeBytes.sol100%100%100%100%
contracts/common/libraries/TransientPrimitives
   TransientPrimitives.sol100%100%100%100%
contracts/governance
   AccessControlRestriction.sol100%100%100%100%
   ChainAdmin.sol97.87%100%100%97.30%39
   ChainAdminOwnable.sol44.83%100%40%45.83%28, 38–40, 46–48, 57, 66, 77–79, 81
   

@0xValera 0xValera marked this pull request as ready for review October 6, 2025 15:03
@0xValera 0xValera merged commit fb6a11d into kl/medium-interop Oct 6, 2025
17 of 23 checks passed
@0xValera 0xValera deleted the vg/sb-server-fixes-cherrypick branch October 6, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants