-
Notifications
You must be signed in to change notification settings - Fork 388
feat: add script for L1 contract verification #1653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Raid5594
wants to merge
2
commits into
draft-v29
Choose a base branch
from
ra/add-script-for-l1-contract-verification
base: draft-v29
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -0,0 +1,182 @@ | |||
#!/usr/bin/env bash | |||
set -euo pipefail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I dislike when we have files that are hard to review manually, most of our codebase/scripts are in TypeScript. Considering that logs are generated inside l1-contracts repo and l1-contracts repo already have ts files, I would prefer it to be a ts script, than a bash one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Adds a bash script to verify contracts on L1, provided with the deployment logs.
Why ❔
When we deploy new contracts with deployment scripts, logs are generated, however the process is pretty manual, so this PR automates it via the scripts that covers da-contracts and l1-contracts folder.
However, it is easily extendable to more directories, in necessary.
Checklist