fix: some fixes for medium-interop review + ERC7786 compatibility changes #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitastupin-matterlabs
approved these changes
Jul 22, 2025
|
It would be good to get the integration tests working locally in core before merging this. Otherwise someone else will have to do it. I added some changes, please branch of here: |
kelemeno
reviewed
Jul 25, 2025
kelemeno
reviewed
Jul 25, 2025
| (sourceChain == L1_CHAIN_ID && sender == L1_ASSET_ROUTER) || | ||
| (sourceChain != L1_CHAIN_ID && sender == address(this)), | ||
| InvalidCaller(sender) | ||
| (senderChainId == L1_CHAIN_ID && senderAddress == L1_ASSET_ROUTER) || |
There was a problem hiding this comment.
I think we don't actually want to allow interop from L1 currently.
There was a problem hiding this comment.
true, addressed 8fe4540
kelemeno
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Decided with Nikita to merge fixes into
kl/medium-interopbranch right away, and having further discussions in github conversations/chats. Merging fixes that are already done.Why ❔
Checklist