-
Notifications
You must be signed in to change notification settings - Fork 285
refactoring TxnEvent to support callback data and return error with callback function (ISCP integration Step 1) #22596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+225
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengttt
approved these changes
Oct 9, 2025
iamlinjunhong
approved these changes
Oct 10, 2025
daviszhen
approved these changes
Oct 10, 2025
LeftHandCold
approved these changes
Oct 10, 2025
zhangxu19830126
approved these changes
Oct 10, 2025
XuPeng-SH
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just a temporary fix to test the functionality; it's not production-ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
What type of PR is this?
Which issue(s) this PR fixes:
issue #22595
What this PR does / why we need it:
refactoring txnevent
PR Type
Enhancement
Description
Refactor TxnEvent callback system to support error handling
Add context parameter to all callback functions
Replace simple function callbacks with TxnEventCallback struct
Update all callback registrations across services
Diagram Walkthrough
File Walkthrough
9 files
Update test mock callback signature
Update mock method signatures and parameters
Update mock TxnOperator callback signature
Update test TxnOperator callback signature
Update test callback signature
Refactor test callbacks with error handling
Update test storage callbacks
Update test with new callback structure
Update test operator callback signature
10 files
Update callback registration with new wrapper
Refactor callback to return error and accept context
Update callback with error handling support
Update service callbacks with new structure
Update client callback registration and handlers
Core refactoring of callback system implementation
Implement new callback structure and error handling
Define TxnEventCallback struct and helper functions
Update storage callback signature
Update trace service callbacks with error handling