Refactoring Bytes to check double free and code cleanup #22251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reusee
requested changes
Jul 24, 2025
fengttt
requested changes
Jul 24, 2025
fengttt
approved these changes
Jul 29, 2025
fengttt
reviewed
Jul 29, 2025
| @@ -130,7 +130,7 @@ func (r *RemoteCache) Read(ctx context.Context, vector *IOVector) error { | |||
| idx := int(cacheData.Index) | |||
| if cacheData.Hit { | |||
| vector.Entries[idx].done = true | |||
| vector.Entries[idx].CachedData = &Bytes{bytes: cacheData.Data} | |||
There was a problem hiding this comment.
@reusee can you please check this line? This is significant. I will be surprised if the old code works, and the new code also works without a leak. Are we fixing a real bug here?
There was a problem hiding this comment.
旧的代码不带引用计数，所以就只是对 []byte 的包装。新的代码改成了引用计数，只要使用方的计数正确，就不会有问题。如果真的有问题，可以另外增加一个 GoBytes 类型，实现 fscache.Data 接口，但不实现引用计数机制。
There was a problem hiding this comment.
OK. Cannot have another type; the ref counting MUST be correct. So great, let's go with this and see if we will hit panic.
Thank you.
fengttt
reviewed
Jul 29, 2025
| @@ -80,8 +85,7 @@ func (b *bytesAllocator) allocateCacheData(size int, hints malloc.Hints) fscache | |||
| bytes: slice, | |||
| deallocator: dec, | |||
| } | |||
| bytes._refs.Store(1) | |||
| bytes.refs = &bytes._refs | |||
| bytes.refs.Store(1) | |||
There was a problem hiding this comment.
Minor, you can do a NewBytes here, so that we can restrict all the Store(1) to one single place.
reusee
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #22250
What this PR does / why we need it:
Bytes to check double free and code cleanup