Remove support for FetchHttpApi without onlyData: true
#4939
+134
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/onlyData_must_die
branch
3 times, most recently
from
eeabc5e to
629ffcd
Compare
richvdh
force-pushed
the
rav/onlyData_must_die
branch
from
629ffcd to
bbccf9c
Compare
richvdh
requested review from
dbkr and
MidhunSureshR
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FetchHttpApiis never used withoutonlyData: true, and there is a bunch of type and code boilerplate to support it. Let's remove support for running withoutonlyData: true, as part of a longer-term mission to remove it altogehter.This PR targets the
vNextbranch, with the intention that it be part of the next major release of the js sdk.