Support for creator power level #4937
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for infinite power level specified by [MSC4289](matrix-org/matrix-spec-proposals#4289).
t3chguy
requested changes
Jul 23, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const createEvent = this.getStateEvents(EventType.RoomCreate, ""); | ||
| if (!createEvent) { | ||
| if (!this.getVersionWarning) { | ||
| logger.warn("[getVersion] Room " + this.roomId + " does not have an m.room.create event"); |
Check warning
Code scanning / SonarCloud
Deprecated APIs should not be used Medium
| return "1"; | ||
| } | ||
| return createEvent.getContent()["room_version"] ?? "1"; | ||
| return this.currentState.getRoomVersion(); |
Check warning
Code scanning / SonarCloud
Deprecated APIs should not be used Medium
as room versions strings aren't ordered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for infinite power level specified by MSC4289.
This version removes powerLevelNorm which we only use in one place in Element Web (where we probably should not) and I'm not sure is generally that sensible, so I've removed it since it's a difficult concept to keep and would at best be a slight lie when one of the PLs is always infinity (eg. we'd have to say creator is also 100, probably). This makes this a BREAKING CHANGE.
I'll leave this as draft until I have a matching PR for element.
Checklist
public/exportedsymbols have accurate TSDoc documentation.