[google_fonts] Add baseUrl config option
#666
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This package is being moved to https://github.com/flutter/packages/tree/main/packages/google_fonts, and PRs aren't transferrable, so I'm going to have to close this. Kindly reopen this PR in that repo if you're interested in landing this PR, I'll be happy to help land it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to the Great Firewall of China, people who lives in the Chinese mainland are likely unable to retrieve font files from gstatic. Config option
baseUrlallows developers to use third-party mirror/proxy offonts.gstatic.com, such asqaq.qa.Issues
Fixes material-foundation/google_fonts_flutter#16
Checklist
CHANGELOG.md