solved problem #3077
solved problem #3077
Conversation
There was a problem hiding this comment.
Review Summary
Great work on implementing the core logic! Your function correctly calculates the number of occurrences and handles case-insensitivity as required. However, this submission requires a change because it's missing the docstring, which is a mandatory part of the task description.
Please add the required docstring to the count_occurrences function to explain its purpose, parameters, and return value.
Additionally, while your for loop is functional, the task guidelines recommended using Python's built-in str.count() method for a more concise solution. Consider this as an improvement for your next submission.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| def count_occurrences(phrase: str, letter: str) -> int: | ||
| # write your code here | ||
| pass | ||
| lowerCase_phrase = phrase.lower() |
There was a problem hiding this comment.
The function is missing the required docstring. Please add the docstring as specified in the task description to explain the function's purpose, parameters, and return value.
| for char in lowerCase_phrase: | ||
| if char == lowerCase_letter: | ||
| count += 1 | ||
| return count |
There was a problem hiding this comment.
While this for loop correctly implements the counting logic, the task guidelines recommend avoiding loops. Python's built-in str.count() method can achieve the same result in a more concise and idiomatic way.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.
2 participants
No description provided.