-
Notifications
You must be signed in to change notification settings - Fork 352
Develop #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Develop #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make sure the demo link is working
And take a look at the minor issues, spotted
src/styles/blocks/_faq.scss
Outdated
.faq { | ||
background: rgba(0, 0, 0, 0.7); | ||
overflow: auto; | ||
width: 100vw; | ||
height: 100vh; | ||
|
||
&__main { | ||
background-color: rgba(25, 21, 54, 1); | ||
height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense move these colors to the constants, as toy use them multiple times
src/styles/blocks/_more.scss
Outdated
@@ -0,0 +1,21 @@ | |||
.more { | |||
background-color: rgba(5, 4, 11, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this one.
src/styles/main.scss
Outdated
body { | ||
background: $c-gray; | ||
background: linear-gradient(100.83deg, #191536 0.67%, #000 100%); | ||
box-shadow: 4px 4px 40px 0 rgba(0, 0, 0, 0.25); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to have body styles reset, while background and box-shadow should be moved to a diferent container, or at least to the class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
https://kami2693.github.io/layout_KateVR/