Skip to content

Conversation

@helloAmulya
Copy link

This PR fixes the issue described in #343 where clicking the "Fundamentals" button caused a full page refresh instead of opening the detailed docs panel.


Root Cause:
The tag template used {t} as the link text, which did not reference the correct variable and caused navigation instead of triggering the intended panel toggle.


Screenshot:
Screenshot 2025-08-16 at 3 43 32 AM


Changes Made:

  • Updated the tag template to use ${t} inside the <a> tag, ensuring the correct text is rendered while preventing unintended page reloads.
// Before
const tag = t => `
<span class="tag">
  <a href="/${p.url}">{t}</a>
</span>
`;

// After
const tag = t => `
<span class="tag">
  <a href="/${p.url}">${t}</a>
</span>
`;

Working Example:

Screen.Recording.2025-08-16.at.3.53.58.AM.mov

Related Issue:
Closes #343

@netlify
Copy link

netlify bot commented Aug 15, 2025

Deploy Preview for masteringjs ready!

Name Link
🔨 Latest commit b141713
🔍 Latest deploy log https://app.netlify.com/projects/masteringjs/deploys/689fb5398b1e920008cb3882
😎 Deploy Preview https://deploy-preview-344--masteringjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@helloAmulya helloAmulya closed this Sep 3, 2025
@helloAmulya helloAmulya reopened this Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fundamentals button refreshes page instead of opening detailed docs panel

1 participant