Skip to content
This repository was archived by the owner on Oct 18, 2024. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Feb 14, 2014

Hey Mark, I just merged your app indicator code into mine, please test this out and maybe merge??

I think some work still needs to be done in the following areas

  1. Where will btsync store its standard config file?
  2. Should we break out the gtk tray stuff into a separate .py and have it get imported?
  3. I change the class name and some documentation stuff, So just a heads up if you do merge it.
  4. Had to remove OS specific package detection, it broke things on my Gentoo system

Right now it tries for appindicator and if that fails uses gtk tray as a fall-back...

Gino McCarty and others added 6 commits February 6, 2014 00:54
@marxjohnson
Copy link
Owner

Hi @teknocrat
I've had to merge your changes in manually, but I think I've managed to get a reasonably elegant and python-style solution in place. However, as I'm on Ubuntu, I can't check that it works! Can you grab the modified indicator script from my gtktrayicon branch and test it out for me?

@ghost
Copy link
Author

ghost commented Feb 24, 2014

Hey sorry for the delay been swamped I'm gonna get to this tonight or tomorrow for sure

On February 22, 2014 10:49:47 AM EST, Mark Johnson [email protected] wrote:

Hi @teknocrat
I've had to merge your changes in manually, but I think I've managed to
get a reasonably elegant and python-style solution in place. However,
as I'm on Ubuntu, I can't check that it works! Can you grab the
modified indicator script from my
gtktrayicon
branch and test it out for me?


Reply to this email directly or view it on GitHub:
#42 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant