Skip to content

Allow using existing socket to initiate IRC session e.g. using SOCKS proxy #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Allow using existing socket to initiate IRC session e.g. using SOCKS proxy #553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f014109
Allow reusing existing socket
e-neko Sep 14, 2015
6ece5d1
Merge branch 'master' of https://github.com/martynsmith/node-irc
e-neko Nov 29, 2019
1989b99
allow attaching to existing connection, e.g. from socks proxy
e-neko Nov 29, 2019
7378317
add myself to contributors
e-neko Nov 29, 2019
2724144
fix whitespace issues
e-neko Nov 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/irc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ function Client(server, nick, opt) {
realName: 'nodeJS IRC client',
port: 6667,
localAddress: null,
existingSocket: null,
debug: false,
showErrors: false,
autoRejoin: false,
Expand Down Expand Up @@ -792,6 +793,11 @@ Client.prototype.connect = function(retryCount, callback) {
util.log(self.conn.authorizationError);
}
});
} else if (self.opt.existingSocket) {
// must be an already connected socket, e.g. from socks proxy
self.conn = self.opt.existingSocket;
// call connection handler asynchronously, emulating connection success
setTimeout(self._connectionHandler.bind(self), 0);
} else {
self.conn = net.createConnection(connectionOpts, self._connectionHandler.bind(self));
}
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"Chris Nehren <[email protected]>",
"Henri Niemeläinen <[email protected]>",
"Alex Miles <[email protected]>",
"Simmo Saan <[email protected]>"
"Simmo Saan <[email protected]>",
"e-neko <[email protected]>"
],
"repository": {
"type": "git",
Expand Down