-
Notifications
You must be signed in to change notification settings - Fork 17
modified for DSM 7.2, 7.1.1, and default to local logger #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure how to assign this to you @markdumay - this also supercedes #62 |
This additional section advises users to stop all containers with compose before upgrade or restores, in order to avoid the errors with persisted logging mechanisms still referring to the DB logging plugin from Synology.
remove dupes from compose enumeration
modified command to identify compose-managed and non compose-managed containers
include tested DSM version 7.2.1
Codefactor issues resolved; not sure how to trigger a re-run |
This is a must for Portainer, some of it's features wouldn't work with ancient Docker 20. Thank you, I've updated docker from your fork without any issues. |
Given that this pull request hasn’t been reviewed in 5 months, and there hasn’t been activity in the project in several years either to @markdumay This is a really awesome foundation you've created. I have and will continue to make sure to credit your original repository in my version. ❤️ I’ll continue to update my version to work with modern DSM versions as much as I'm able to. |
This modification fixes the name of the package and the packages directory from
Docker
toContainerManager
for DSM 7.2It also changes the default logger to the local file logging driver which is a more efficient driver than the JSON File logging driver and also does file rotations by default, avoiding the potential issue of running out of file space on your host due to much larger and non-rotated log files accumulating.
I have not run into issues with this so far; I am able to start and stop containers from the Container Manager UI, all of my containers were able to run fine on custom network or default bridge with no issues. The only issue is the absense of any logs in the Container Manager UI.
docker log
works just fine, as do log-exposure apps likedozzle
.From the Docker documentation: