Fix/log blocked chan

[frinfo702]

This pull request introduces error handling improvements for blocked notification channels and includes a minor cleanup in the server/server.go file. The most significant changes enhance logging and error reporting when notification channels are blocked.

Error handling improvements:

• func (s *MCPServer) SendNotificationToAllClients: Added logic to log an error using s.hooks.onError when a notification channel is blocked, including the session ID and method name in the error message.
• func (s *MCPServer) SendNotificationToClient: Enhanced error reporting by logging blocked notification channels with s.hooks.onError, providing session ID and method details, and returning a descriptive error message.

Code cleanup:

• func (s *MCPServer) AddResourceTemplate: Removed an unnecessary blank line for minor code cleanup.

Summary by CodeRabbit

• Bug Fixes
  • Improved error reporting when notification channels are blocked during notification delivery.
• Style
  • Removed an unnecessary blank line in the resource template addition method.

[coderabbitai]

Walkthrough

The update introduces error reporting via hooks for scenarios where notification channels are blocked during notification delivery in the server logic. Specifically, when a notification cannot be sent to a client or all clients due to a full channel, the code now triggers the configured error hook with details about the blocked channel and the relevant method. Additionally, a redundant blank line was removed from an unrelated method. No changes were made to the signatures or declarations of exported or public entities.

Changes

Files	Change Summary
server/server.go	Added error hook calls when notification channels are blocked in notification-sending methods; removed an extraneous blank line in AddResourceTemplate.

Possibly related PRs

• Add per-session notifications handling #46: Refactors notification handling to use per-session notification channels and session management interfaces, modifying related notification sending code but focusing on different aspects of notification handling.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 412401c and 4c2a6ec.

📒 Files selected for processing (1)

• server/server.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• server/server.go

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dugenkui03]

maybe you could wrap the error as requestError with INTERNAL_ERROR = -32603 , then the OnErrorHookFunc will know the error type.

[frinfo702]

Thank you for the explanation. I’ve applied it to my code.