-
Notifications
You must be signed in to change notification settings - Fork 346
fix(sse): don't throw error when get http.StatusNoContent #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(sse): don't throw error when get http.StatusNoContent #153
Conversation
Signed-off-by: ZheNing Hu <[email protected]>
WalkthroughThe update modifies the HTTP status code handling logic in the Changes
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -305,7 +305,8 @@ func (c *SSEMCPClient) sendRequest( | |||
defer resp.Body.Close() | |||
|
|||
if resp.StatusCode != http.StatusOK && | |||
resp.StatusCode != http.StatusAccepted { | |||
resp.StatusCode != http.StatusAccepted && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sse handling has been moved to a separate transport in the transport
dir. Could you pull in the latest changes and add your fix here
mcp-go/client/transport/sse.go
Line 284 in b46fa54
if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusAccepted { |
In our scenario, the successful return value of the MCP SSE server initialize request is 204 NoContent, which currently causes the SSE initialization to fail. Therefore, modify the sendRequest function to also handle http.StatusNoContent to prevent errors from being thrown.
Summary by CodeRabbit